Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first Reader implicit instantiation #126

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Fix first Reader implicit instantiation #126

merged 3 commits into from
Jul 17, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Jul 16, 2017

Fixes the same as #105

@codecov-io
Copy link

codecov-io commented Jul 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@38f42ea). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage          ?   55.65%           
  Complexity        ?      209           
=========================================
  Files             ?       90           
  Lines             ?     1335           
  Branches          ?      174           
=========================================
  Hits              ?      743           
  Misses            ?      518           
  Partials          ?       74
Impacted Files Coverage Δ Complexity Δ
kategory/src/main/kotlin/kategory/data/Reader.kt 75% <75%> (ø) 3 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f42ea...259608d. Read the comment docs.

Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about what's happening but I am using kategory 0.3.3 here and I am using the Kleisli without any errors. But just in case I reference val id = Id() in my application class previously.

@ffgiraldez ffgiraldez merged commit d7e0013 into master Jul 17, 2017
@ffgiraldez ffgiraldez deleted the paco-readerfix branch July 17, 2017 07:02
@wiyarmir wiyarmir mentioned this pull request Jul 17, 2017
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
* Remove internal atomic instances and atomic-fu from arrow-core

Replaced usage in EvalTests by a normal atomic

* Remove unsupported op, replace with Java's atomic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants