MonadError Laws #122
Merged
MonadError Laws #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
========================================
Coverage ? 55.5%
Complexity ? 198
========================================
Files ? 80
Lines ? 1171
Branches ? 167
========================================
Hits ? 650
Misses ? 453
Partials ? 68
Continue to review full report at Codecov.
|
pakoito
approved these changes
Jun 27, 2017
| @@ -1,6 +1,6 @@ | |||
| package kategory | |||
|
|
|||
| class EitherMonad<L> : Monad<EitherF<L>> { | |||
| open class EitherMonad<L> : Monad<EitherF<L>> { | |||
There was a problem hiding this comment.
I'd rather it used delegation rather than inheritance like in here: https://github.com/kategory/kategory/blob/master/kategory/src/main/kotlin/kategory/instances/Composed.kt#L39
There was a problem hiding this comment.
Sounds good, we can do a pass to redo all of them if this makes sense. Let's discuss by chat.
Merged
ambrusadrianz
pushed a commit
to ambrusadrianz/arrow
that referenced
this pull request
Oct 22, 2019
* add std kotlin instances test * add java instances test * add arrow instances test * format * allow missing key for None fields * code clean up * format * add instances bad cases * add instances java time bad cases * add instances java bad cases * add instances collections bad cases * add instances arrow bad cases * fix some decoders according to test spectations * merge master * wip more code cleanup * format and clean up * Simplify optics internals * make functions private
rachelcarmena
pushed a commit
that referenced
this pull request
Feb 24, 2021
rachelcarmena
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Maintain `Traverse` and `TraverseFilter` documents * Modify a sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tests and instances for Try and Either