Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Cli: update repository signing key #7191

Closed
wants to merge 1 commit into from
Closed

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 8, 2024

Description

We are using binary key for adding repository. Close #7186

This needs to be done differently one day.

Documentation summary for feature / change

GH changed their signing key. Lets update it.

How Has This Been Tested?

Not tested, just key replacement.

Checklist:

  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Desktop Graphical user interface labels Sep 8, 2024
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 8, 2024
@williammartin williammartin mentioned this pull request Sep 8, 2024
5 tasks
@williammartin
Copy link
Contributor

Thanks. Downloaded the file from this PR and imported into GPG to check it was the correct key and looks good to me.

➜  ~ gpg --import githubcli.gpg githubcli\ \(1\).gpg
gpg: key 23F3D4EA75716059: public key "GitHub CLI <[email protected]>" imported
gpg: key 23F3D4EA75716059: "GitHub CLI <[email protected]>" not changed
gpg: Total number processed: 2
gpg:               imported: 1
gpg:              unchanged: 1
➜  ~ gpg --list-keys
[keyboxd]
---------
pub   rsa4096 2022-09-06 [SC] [expires: 2026-09-05]
      2C6106201985B60E6C7AC87323F3D4EA75716059
uid           [ unknown] GitHub CLI <[email protected]>
sub   rsa4096 2022-09-06 [E] [expires: 2026-09-05]

@igorpecovnik igorpecovnik deleted the update-ghcli-key branch November 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Bugfix Pull request is fixing a bug Desktop Graphical user interface Needs review Seeking for review size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

[Bug]: GPG error signatures were invalid: EXPKEYSIG 23F3D4EA75716059
2 participants