Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting the target entropy #43

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

jan1854
Copy link
Collaborator

@jan1854 jan1854 commented Apr 5, 2024

Description

Fixes #42 by adding a target_entropy argument to SAC and TQC. This is needed to ensure compatibility with rl-baselines3-zoo. The behavior is the same as in stable-baselines3 / sb3-contrib'. I also added the argument to CrossQ for consistency.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@jan1854 jan1854 mentioned this pull request Apr 5, 2024
3 tasks
Copy link
Owner

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit fcd647e into master Apr 8, 2024
4 checks passed
@araffin araffin deleted the feat/tqc_target_entropy_arg branch April 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TQC Entropy Coefficient
2 participants