Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitLoc to git.branch #944

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Conversation

radding
Copy link
Contributor

@radding radding commented Jan 30, 2019

With out git loc in the branch call, apollo will fail on schema pushes with the following error:

  ✔ Loading Apollo Project
  ✖ Uploading service to Engine
    → [git-rev-sync] no git repository found
Error: [git-rev-sync] no git repository found
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:47:11)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at Object.branch (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:79:16)
    at Object.exports.gitInfo (/usr/local/lib/node_modules/apollo/lib/git.js:60:26)

This happens when you tag a build in CircleCI because it sets branch to an empty variable.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link

@radding: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

radding and others added 3 commits January 31, 2019 10:51
With out git loc in the branch call, apollo will fail on schema pushes with the following error: 

```bash
  ✔ Loading Apollo Project
  ✖ Uploading service to Engine
    → [git-rev-sync] no git repository found
Error: [git-rev-sync] no git repository found
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:47:11)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
    at Object.branch (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:79:16)
    at Object.exports.gitInfo (/usr/local/lib/node_modules/apollo/lib/git.js:60:26)```
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving this issue! If you don't mind giving the changelog one more update (bump your entry into the Upcoming section, I'll merge this in 😄

@radding
Copy link
Contributor Author

radding commented Feb 20, 2019

@trevor-scheer Done!

@trevor-scheer trevor-scheer merged commit 5f3380b into apollographql:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants