Add gitLoc to git.branch #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radding: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
With out git loc in the branch call, apollo will fail on schema pushes with the following error:
```bash
✔ Loading Apollo Project
✖ Uploading service to Engine
→ [git-rev-sync] no git repository found
Error: [git-rev-sync] no git repository found
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:47:11)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10)
at Object.branch (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:79:16)
at Object.exports.gitInfo (/usr/local/lib/node_modules/apollo/lib/git.js:60:26)```
trevor-scheer
approved these changes
Feb 6, 2019
|
@trevor-scheer Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With out git loc in the branch call, apollo will fail on schema pushes with the following error:
✔ Loading Apollo Project ✖ Uploading service to Engine → [git-rev-sync] no git repository found Error: [git-rev-sync] no git repository found at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:47:11) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:75:10) at Object.branch (/usr/local/lib/node_modules/apollo/node_modules/git-rev-sync/index.js:79:16) at Object.exports.gitInfo (/usr/local/lib/node_modules/apollo/lib/git.js:60:26)This happens when you tag a build in CircleCI because it sets branch to an empty variable.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.