Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration loading and schema tag support #925

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Jan 25, 2019

This gets the extension and configuration back in a better state. No promises that all monorepo issues are resolved, but these fix blocking bugs (bugs which, ironically, prevent us from being able to properly use the extension on the tooling repo).

I found these bugs when trying to update our config to use service: engine@master.

  • Cosmiconfig looks UP for configs from a provided config. This means that
    any package.json (in our case, one for each repo - none of which need an apollo config) could send
    cosmiconfig to the parent - causing lots of dir weirdness. Filter out package.json files that don't
    contain an apollo config.

Update our apollo.config.js to point to engine@master

  • Incidentally found and fixed a bug related to providing the schema tag via the @. The @tag is no
    longer left behind when it's provided.

 * Cosmiconfig looks UP for configs from a provided config. This means that
   any package.json could send cosmiconfig to the parent - causing lots of
   dir weirdness. Filter out package.json files that don't contain an apollo
   config.

Update apollo.config.js to point to engine@master
 * Incidentally found and fixed a bug related to providing the schema tag
   via the @. The @tag is no longer left behind when it's provided.
…provided.

Priority for choosing the tag name should be:
flag -> config -> "current"

With a default flag set, that default would always defeat the tag provided via config.
@trevor-scheer trevor-scheer force-pushed the trevor/fix-config-loading branch from 71e965a to c0d20ce Compare January 25, 2019 19:42
@trevor-scheer trevor-scheer changed the title Fix blocking extension / configuration bugs Fix configuration loading and schema tag support Jan 25, 2019
@trevor-scheer trevor-scheer merged commit 80bec81 into master Jan 25, 2019
@trevor-scheer trevor-scheer deleted the trevor/fix-config-loading branch April 2, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant