Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support status bar command and service stats logging #840

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Support status bar command and service stats logging #840

merged 4 commits into from
Jan 17, 2019

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Dec 18, 2018 •
edited
Loading

Goals

  • Add an action to the action bar item at the bottom of the VSCode editor that opens up the output for the Apollo extension and prints out basic service info
  • Add support on the language server for reporting that service info
  • Supports multiple projects open in the workspace (like in a monorepo). Stats printed are for the project associated with the open file. If no file is open, it just prints extension version

Client projects when loaded successfully:
screen shot 2019-01-10 at 4 34 45 pm

Error when projects can't load stats (either because of misconfiguration or other language server/extension errors):
screen shot 2019-01-10 at 4 35 20 pm

Note: Service projects currently aren't supported for stats, so clicking the status bar icon just prints the extension version and opens the output pane

@JakeDawkins JakeDawkins force-pushed the AT-9 branch 2 times, most recently from 24d30ae to d6810d3 Compare January 9, 2019 18:12
@JakeDawkins JakeDawkins changed the title [WIP] Support action bar command and service stats logging Support action bar command and service stats logging Jan 10, 2019
abernix
abernix reviewed Jan 11, 2019
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Just a few unsolicited comments!

@JakeDawkins JakeDawkins force-pushed the AT-9 branch 2 times, most recently from cc54122 to 7d29070 Compare January 17, 2019 17:51
@JakeDawkins JakeDawkins changed the title Support action bar command and service stats logging Support status bar command and service stats logging Jan 17, 2019
@JakeDawkins
Added status bar stats printing
3739f4f 
* Added action to vscode to request stats
* Linked status bar onclick to run stats action
* Added stats printing utils for output pane
* Added languageProvider method to request stats from projects
* Added ability to run commands from a parent dir for monorepo support in editors
@JakeDawkins
fileSet.allFiles to use configPath when present to lookup project files
ca1c58f
@JakeDawkins
Change FileSet to accept and use URIs instead of string paths
b228665
@JakeDawkins JakeDawkins merged commit 1b34e65 into master Jan 17, 2019
@JakeDawkins JakeDawkins deleted the AT-9 branch January 17, 2019 23:45
glasser added a commit that referenced this pull request Jun 16, 2020
@glasser
vscode-apollo: Fix 'Apollo: Show Status' command
a82ef67 
It was registered under the wrong name since its introduction in #840.
@glasser glasser mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abernix abernix abernix left review comments

@trevor-scheer trevor-scheer trevor-scheer left review comments

@jbaxleyiii jbaxleyiii Awaiting requested review from jbaxleyiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeDawkins @abernix @trevor-scheer