Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Use tagName from config to extract documents. #769

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Nov 30, 2018

Now other tags (such as Relay’s graphql tag) will actually be recognized with a apollo.config.js file like the following:

module.exports = {
  client: {
    service: {
      name: "local",
      localSchemaFile: "./data/schema.graphql",
    },
    includes: ["src/**/*.{ts,tsx,graphql}"],
    excludes: ["**/node_modules", "**/__tests__"],
    tagName: "graphql",
  }
}

@jbaxleyiii
Copy link
Contributor

@alloy 👋 thanks for doing this! Does this mean the language server / extension will support Relay projects now? If so that would be really really awesome!

@jbaxleyiii jbaxleyiii merged commit c4ccd53 into apollographql:master Nov 30, 2018
@alloy
Copy link
Contributor Author

alloy commented Nov 30, 2018

@jbaxleyiii Yup, it does, that’s what we use 👍 Navigating with the extension is feeling pretty sweet thus far!

Btw, can you offer any insight into how long it would take for this to make it into a published release?

@jbaxleyiii
Copy link
Contributor

@alloy that's awesome! Release should be out today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants