Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loadConfigFromFile #591

Merged
merged 2 commits into from
Sep 23, 2018
Merged

Fix loadConfigFromFile #591

merged 2 commits into from
Sep 23, 2018

Conversation

WaldoJeffers
Copy link
Contributor

Fixes apollographql/rover#549

Current implementation resolves the config file as a node module, making it impossible to actually pass a config file

@ghost ghost added blocking 🎉 feature New addition or enhancement to existing solutions labels Sep 13, 2018
@shadaj
Copy link
Contributor

shadaj commented Sep 22, 2018

@WaldoJeffers this looks great, but looks like linting is failing. Could you run npm run lint-fix from the base apollo-cli director?

@WaldoJeffers
Copy link
Contributor Author

@shadaj Sure thing :)

Copy link
Contributor

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@shadaj shadaj merged commit 87d27be into apollographql:master Sep 23, 2018
@WaldoJeffers WaldoJeffers deleted the patch-3 branch September 24, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] How provide config file to apollo-cli ?
2 participants