Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openssl): d2i_ECDSA_SIG API parameter pp type error #15

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Oct 23, 2024

https://docs.openssl.org/1.0.2/man3/ecdsa/#synopsis

image

If multiple libraries use this API separately, but their declared function parameter types are inconsistent, it may cause other libraries to be unable to call correctly.

Because when redefining declarations in ffi.cdef, they will be overwritten, and their handling methods will vary depending on the parameter types.

It should be used according to the officially defined types of openssl.

resty/openssl/auxiliary/ecdsa.lua:51: bad argument #2 to 'd2i_ECDSA_SIG' (cannot convert 'const unsigned char *[1]' to 'unsigned char **')

@AlinsRan AlinsRan requested a review from membphis October 23, 2024 03:16
@AlinsRan AlinsRan merged commit f370e03 into master Oct 23, 2024
2 checks passed
@nic-6443 nic-6443 deleted the fix/d2i_ECDSA_SIG branch October 23, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants