Check the input yaml and the path in ACL #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Oct 19, 2023
| @@ -31,6 +31,7 @@ | |||
| import org.apache.rocketmq.remoting.RPCHook; | |||
| import org.apache.rocketmq.remoting.protocol.RemotingCommand; | |||
| import org.yaml.snakeyaml.Yaml; | |||
| import org.yaml.snakeyaml.constructor.SafeConstructor; | |||
There was a problem hiding this comment.
Plz remove useless import
Codecov Report
@@ Coverage Diff @@
## develop #7475 +/- ##
=============================================
+ Coverage 42.53% 42.99% +0.46%
- Complexity 9441 9669 +228
=============================================
Files 1150 1161 +11
Lines 82746 83926 +1180
Branches 10778 10898 +120
=============================================
+ Hits 35196 36084 +888
- Misses 43139 43374 +235
- Partials 4411 4468 +57
... and 97 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #issue_id
Brief Description
How Did You Test This Change?