Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #97] fix wrong judg of toLmqMessage and add ut #98

Merged
merged 1 commit into from
May 16, 2022
Merged

[ISSUE #97] fix wrong judg of toLmqMessage and add ut #98

merged 1 commit into from
May 16, 2022

Conversation

YxAc
Copy link
Contributor

@YxAc YxAc commented May 15, 2022

fix #97


lmqQueueStoreManager.pullMessage("test", new Queue(), new QueueOffset(), 1);

verify(mqClientAPI).pullMessage(any(), any(), anyLong(), any(), any());
}

@Test
public void testToLmqPullRequest() throws InvocationTargetException, NoSuchMethodException, IllegalAccessException {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test toLmqPullRequest included toLmqMessage

@codecov-commenter
Copy link

Codecov Report

Merging #98 (8e27eb2) into main (ac90d5c) will increase coverage by 1.28%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   44.04%   45.33%   +1.28%     
==========================================
  Files          98       98              
  Lines        4200     4200              
  Branches      656      656              
==========================================
+ Hits         1850     1904      +54     
+ Misses       2016     1948      -68     
- Partials      334      348      +14     
Impacted Files Coverage Δ
...e/rocketmq/mqtt/ds/store/LmqQueueStoreManager.java 51.16% <50.00%> (+25.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac90d5c...8e27eb2. Read the comment docs.

@pingww pingww merged commit 4002cff into apache:main May 16, 2022
@YxAc YxAc deleted the fix_wrong_judg_toLmqMessage branch May 16, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong judgment when toLmqMessage
3 participants