Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a subscription storage interface #79

Merged
merged 11 commits into from
Apr 24, 2022
Merged

Conversation

pingww
Copy link
Contributor

@pingww pingww commented Apr 22, 2022

In order to realize the subscription storage capability in the session storage of the MQTT protocol, We define a subscription storage interface.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 31.13%. Comparing base (344cb70) to head (0c16e03).
Report is 278 commits behind head on main.

Files with missing lines Patch % Lines
...rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java 50.00% 8 Missing and 3 partials ⚠️
.../apache/rocketmq/mqtt/common/util/SpringUtils.java 0.00% 6 Missing ⚠️
...mqtt/ds/upstream/processor/SubscribeProcessor.java 70.00% 1 Missing and 2 partials ⚠️
...tt/ds/upstream/processor/UnSubscribeProcessor.java 66.66% 1 Missing and 2 partials ⚠️
...a/org/apache/rocketmq/mqtt/cs/starter/Startup.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   30.35%   31.13%   +0.77%     
==========================================
  Files          97       98       +1     
  Lines        4191     4237      +46     
  Branches      661      671      +10     
==========================================
+ Hits         1272     1319      +47     
+ Misses       2676     2666      -10     
- Partials      243      252       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants