Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #71] Rename WebsocketEncoder to WebSocketEncoder and add test #72

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[ISSUE #71] Rename WebsocketEncoder to WebSocketEncoder and add test #72

merged 1 commit into from
Apr 18, 2022

Conversation

YxAc
Copy link
Contributor

@YxAc YxAc commented Apr 17, 2022

fixed #71

  • rename WebsocketEncoder to WebSocketEncoder;
  • add unit test

@codecov-commenter
Copy link

Codecov Report

Merging #72 (b1202d0) into main (1393642) will increase coverage by 0.52%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   26.91%   27.44%   +0.52%     
==========================================
  Files          97       97              
  Lines        4187     4187              
  Branches      660      660              
==========================================
+ Hits         1127     1149      +22     
+ Misses       2832     2803      -29     
- Partials      228      235       +7     
Impacted Files Coverage Δ
...rg/apache/rocketmq/mqtt/cs/starter/MqttServer.java 0.00% <0.00%> (ø)
...rocketmq/mqtt/cs/protocol/ws/WebSocketEncoder.java 100.00% <100.00%> (ø)
...mq/mqtt/cs/protocol/ws/WebSocketServerHandler.java 39.53% <0.00%> (+39.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1393642...b1202d0. Read the comment docs.

Copy link
Contributor

@tianliuliu tianliuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 9259af6 into apache:main Apr 18, 2022
@YxAc YxAc deleted the rename_WebSocketEncoder_and_add_test branch April 18, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebsocketEncoder should be named WebSocketEncoder
4 participants