Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #42] optimize func of Trie more readable and increase its codeCov to 100% #43

Merged
merged 1 commit into from
Mar 25, 2022
Merged

[ISSUE #42] optimize func of Trie more readable and increase its codeCov to 100% #43

merged 1 commit into from
Mar 25, 2022

Conversation

YxAc
Copy link
Contributor

@YxAc YxAc commented Mar 24, 2022 •
edited
Loading

optimize #42

1）recursive function of 'findValue'

  • first match the leaf node of mqtt-topic and trie
  • match '#' only once

2）variable 'jinMatch' to 'numberMatch' for consistent

3）make codeCov 100% method and 90% line

tianliuliu
tianliuliu approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@tianliuliu tianliuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duhenglucky duhenglucky merged commit 09cfe62 into apache:main Mar 25, 2022
@YxAc YxAc deleted the optimize_trie_and_increase_codeCov branch March 27, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duhenglucky duhenglucky duhenglucky approved these changes

@tianliuliu tianliuliu tianliuliu approved these changes

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YxAc @duhenglucky @tianliuliu @RongtongJin