Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #38][part 1] just add prometheus frame support #39

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

tianliuliu
Copy link
Contributor

just add prometheus exporter frame

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Attention: Patch coverage is 0% with 450 lines in your changes missing coverage. Please review.

Project coverage is 19.25%. Comparing base (f132bb2) to head (cf9dbc6).
Report is 297 commits behind head on main.

Files with missing lines Patch % Lines
...he/rocketmq/mqtt/exporter/http/MqttHTTPServer.java 0.00% 190 Missing ⚠️
...tmq/mqtt/exporter/http/BackedFileOutputStream.java 0.00% 87 Missing ⚠️
.../mqtt/exporter/collector/MqttMetricsCollector.java 0.00% 82 Missing ⚠️
...ketmq/mqtt/exporter/collector/MqttMetricsInfo.java 0.00% 23 Missing ⚠️
...mqtt/exporter/collector/MetricsBuilderFactory.java 0.00% 19 Missing ⚠️
...rg/apache/rocketmq/mqtt/exporter/MqttExporter.java 0.00% 13 Missing ⚠️
...pache/rocketmq/mqtt/cs/starter/ExporterServer.java 0.00% 10 Missing ⚠️
...rg/apache/rocketmq/mqtt/cs/config/ConnectConf.java 0.00% 8 Missing ⚠️
...he/rocketmq/mqtt/exporter/collector/SubSystem.java 0.00% 8 Missing ⚠️
...q/mqtt/exporter/exception/PrometheusException.java 0.00% 6 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   21.58%   19.25%   -2.34%     
==========================================
  Files          87       96       +9     
  Lines        3716     4166     +450     
  Branches      609      666      +57     
==========================================
  Hits          802      802              
- Misses       2697     3147     +450     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit ab353d0 into apache:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants