Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Group ID separator #129

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Unified Group ID separator #129

merged 1 commit into from
Aug 1, 2022

Conversation

DongyuanPan
Copy link
Contributor

Unified Group ID separator to "%"

@codecov-commenter
Copy link

Codecov Report

Merging #129 (8cdf474) into develop (ee3c4f6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #129   +/-   ##
========================================
  Coverage    41.95%   41.95%           
========================================
  Files          118      118           
  Lines         4900     4900           
  Branches       713      713           
========================================
  Hits          2056     2056           
  Misses        2490     2490           
  Partials       354      354           
Impacted Files Coverage Δ
...apache/rocketmq/mqtt/meta/raft/MqttRaftServer.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing added the bug Something isn't working label Jul 31, 2022
@ShannonDing ShannonDing merged commit af50ca0 into apache:develop Aug 1, 2022
@DongyuanPan DongyuanPan deleted the dev branch August 4, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants