[ISSUE #124] add snapshot to raft state machine #127
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #127 +/- ##
===========================================
- Coverage 43.13% 41.95% -1.18%
===========================================
Files 114 118 +4
Lines 4766 4900 +134
Branches 697 713 +16
===========================================
Hits 2056 2056
- Misses 2356 2490 +134
Partials 354 354
|
| @@ -52,10 +57,13 @@ public class MqttStateMachine extends StateMachineAdapter { | |||
|
|
|||
| private volatile String leaderIp = "unknown"; | |||
|
|
|||
| private SnapshotOperation snapshotOperation; | |||
There was a problem hiding this comment.
snapshotOperation is not used in this file, maybe it should be delete
| public MqttStateMachine(MqttRaftServer server, StateProcessor processor, String groupId) { | ||
| this.server = server; | ||
| this.processor = processor; | ||
| this.groupId = groupId; | ||
| this.snapshotOperation = this.processor.loadSnapshotOperate(); |
There was a problem hiding this comment.
This parameter is not used in this file
|
|
||
| public abstract class StateProcessor { | ||
|
|
||
| public abstract Response onReadRequest(ReadRequest request); | ||
|
|
||
| public abstract Response onWriteRequest(WriteRequest log); | ||
|
|
||
| public SnapshotOperation loadSnapshotOperate() { |
There was a problem hiding this comment.
onSnapshotSave/onSnapshotLoad is used to do Snapshot Operate.
SnapshotOperation maybe can be a implementation of onSnapshotSave/onSnapshotLoad， it can be delete
| @@ -62,6 +72,24 @@ public Response onWriteRequest(WriteRequest writeRequest) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public SnapshotOperation loadSnapshotOperate() { | |||
There was a problem hiding this comment.
snapshotOperation can be init in constructor， or init function with @PostConstruct
There was a problem hiding this comment.
However, you should consider that the user must use this framework for snapshot operations. This may be achieved through design such as inheritance
ShannonDing
changed the title
#124