-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #70]Add retained message #118
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please fix travis ci |
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 45.01% 44.09% -0.93%
==========================================
Files 107 109 +2
Lines 4567 4887 +320
Branches 676 726 +50
==========================================
+ Hits 2056 2155 +99
- Misses 2157 2371 +214
- Partials 354 361 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. |
add some unit tests |
The KV will be removed and the code can be submitted to the Develop branch based on the state machine |
close due to #131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #70
Implement retained messages via kv store