Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #70]Add retained message #118

Closed
wants to merge 10 commits into from
Closed

[ISSUE #70]Add retained message #118

wants to merge 10 commits into from

Conversation

YYYYWD
Copy link
Contributor

@YYYYWD YYYYWD commented Jun 28, 2022

close #70
Implement retained messages via kv store

@YYYYWD
Copy link
Contributor Author

YYYYWD commented Jun 28, 2022

#70

@DongyuanPan
Copy link
Contributor

please fix travis ci

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #118 (b9ff16a) into main (0d8ecf3) will decrease coverage by 0.92%.
The diff coverage is 32.87%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   45.01%   44.09%   -0.93%     
==========================================
  Files         107      109       +2     
  Lines        4567     4887     +320     
  Branches      676      726      +50     
==========================================
+ Hits         2056     2155      +99     
- Misses       2157     2371     +214     
- Partials      354      361       +7     
Impacted Files Coverage Δ
...g/apache/rocketmq/mqtt/common/model/Constants.java 0.00% <ø> (ø)
...rg/apache/rocketmq/mqtt/cs/session/QueueFresh.java 90.00% <ø> (ø)
...ketmq/mqtt/ds/meta/RetainedPersistManagerImpl.java 3.33% <3.33%> (ø)
...cs/protocol/mqtt/handler/MqttSubscribeHandler.java 42.70% <4.08%> (-40.97%) ⬇️
...e/rocketmq/mqtt/ds/store/LmqQueueStoreManager.java 51.85% <41.17%> (+0.68%) ⬆️
...q/mqtt/ds/upstream/processor/PublishProcessor.java 66.66% <47.36%> (-33.34%) ⬇️
...che/rocketmq/mqtt/cs/session/infly/PushAction.java 57.57% <57.14%> (-0.32%) ⬇️
...va/org/apache/rocketmq/mqtt/common/model/Trie.java 81.62% <73.91%> (-4.71%) ⬇️
...org/apache/rocketmq/mqtt/common/model/Message.java 74.46% <88.88%> (+1.21%) ⬆️
...org/apache/rocketmq/mqtt/common/util/TrieUtil.java 93.75% <93.75%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@pingww
Copy link
Contributor

pingww commented Jul 8, 2022

add some unit tests

@DongyuanPan
Copy link
Contributor

The KV will be removed and the code can be submitted to the Develop branch based on the state machine

@ShannonDing ShannonDing changed the title Add retained message [ISSUE #70]Add retained message Aug 1, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 1, 2022
@ShannonDing ShannonDing added the duplicate This issue or pull request already exists label Aug 1, 2022
@ShannonDing
Copy link
Member

close due to #131.

@ShannonDing ShannonDing closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To support Retain Message Feature
5 participants