Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tls tcp server #115

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Support tls tcp server #115

merged 1 commit into from
Jul 1, 2022

Conversation

ChangingFond
Copy link
Contributor

@ChangingFond ChangingFond commented Jun 11, 2022 •
edited
Loading

ref #51

@ChangingFond ChangingFond changed the title support tls tcp server Support tls tcp server Jun 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #115 (c8922c8) into main (3a8b982) will decrease coverage by 3.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   48.47%   45.01%   -3.46%     
==========================================
  Files          98      107       +9     
  Lines        4227     4567     +340     
  Branches      659      676      +17     
==========================================
+ Hits         2049     2056       +7     
- Misses       1824     2157     +333     
  Partials      354      354
Impacted Files Coverage Δ
...rg/apache/rocketmq/mqtt/cs/config/ConnectConf.java 0.00% <0.00%> (ø)
...ache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java 0.00% <0.00%> (ø)
...rg/apache/rocketmq/mqtt/cs/starter/MqttServer.java 0.00% <0.00%> (ø)
...rg/apache/rocketmq/mqtt/ds/config/ServiceConf.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/mqtt/meta/util/SpringUtil.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/mqtt/meta/config/MetaConf.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/mqtt/meta/starter/Startup.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/mqtt/meta/core/MetaClient.java 0.00% <0.00%> (ø)
...he/rocketmq/mqtt/meta/config/MetaConfListener.java 0.00% <0.00%> (ø)
...ava/org/apache/rocketmq/mqtt/meta/util/IpUtil.java 16.66% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8b982...c8922c8. Read the comment docs.

tianliuliu
tianliuliu approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@tianliuliu tianliuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DongyuanPan
DongyuanPan reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@DongyuanPan DongyuanPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

pingww
pingww reviewed Jun 24, 2022
View reviewed changes
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
InputStream keyStream = new ClassPathResource(KEY_FILE_NAME).getInputStream();
SslContextBuilder contextBuilder = SslContextBuilder.forServer(certStream, keyStream);
contextBuilder.clientAuth(ClientAuth.OPTIONAL);
contextBuilder.sslProvider(SslProvider.JDK);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK's ssl performance is relatively poor, it is recommended to use openssl

@tianliuliu
Copy link
Contributor

tianliuliu commented Jul 1, 2022 •
edited
Loading

link #51

@tianliuliu tianliuliu merged commit 0d8ecf3 into apache:main Jul 1, 2022
@ChangingFond ChangingFond mentioned this pull request Jul 14, 2022
Merged
@ChangingFond ChangingFond deleted the tls-server branch July 14, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingww pingww pingww left review comments

@DongyuanPan DongyuanPan DongyuanPan left review comments

@tianliuliu tianliuliu tianliuliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChangingFond @codecov-commenter @tianliuliu @pingww @DongyuanPan