Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong future completed condition #88

Closed
pingww opened this issue Apr 24, 2022 · 0 comments · Fixed by #140
Closed

Wrong future completed condition #88

pingww opened this issue Apr 24, 2022 · 0 comments · Fixed by #140
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pingww
Copy link
Contributor

pingww commented Apr 24, 2022

The future result size is a fault, should be queue's size, not subscription's size

rocketmq-mqtt/mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java

Line 278 in e0b5e20

AtomicInteger result = new AtomicInteger(subscriptions.size());

@tianliuliu tianliuliu added bug Something isn't working good first issue Good for newcomers labels Apr 27, 2022
@shendongsd shendongsd mentioned this issue May 5, 2022
Closed
pingww added a commit to pingww/rocketmq-mqtt that referenced this issue Aug 26, 2022
@pingww
fix apache#88
93a9855
@pingww pingww mentioned this issue Aug 26, 2022
Merged
@pingww pingww closed this as completed Aug 26, 2022
pingww added a commit that referenced this issue Aug 26, 2022
@pingww
Merge pull request #140 from pingww/main
0fb52d1 
fix #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@pingww @tianliuliu