Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code can be Optimize #6

Closed
tianliuliu opened this issue Mar 8, 2022 · 0 comments · Fixed by #7
Closed

Some code can be Optimize #6

tianliuliu opened this issue Mar 8, 2022 · 0 comments · Fixed by #7

Comments

@tianliuliu
Copy link
Contributor

there are some code can be Optimized in main branch

image

such as the queueName variable and can use if else in the condition "TopicUtils.isP2P(secondTopic)"
@tianliuliu tianliuliu mentioned this issue Mar 8, 2022
Merged
duhenglucky pushed a commit that referenced this issue Mar 8, 2022
@tianliuliu
[ISSUE #6] Some code can be Optimize (#7)
87c1ca7 
* for optimize same code

* for optimize same code and add unit test

* for optimize same code and add unit test 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6] Some code can be Optimize tianliuliu/rocketmq-mqtt
1 participant
@tianliuliu