Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #570] ASoC runtime optimization: Cassandra connectors #587

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

imaffe
Copy link
Contributor

@imaffe imaffe commented Jul 5, 2020

What is the purpose of the change

  1. implement Cassandra source/sink connectors

Brief changelog

  1. added Cassandra sink and source connector implementations

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@imaffe
Copy link
Contributor Author

imaffe commented Jul 5, 2020

  1. the rat check failed because of a requirment.txt, but I looked at other Apache python projects (like airflow), it seems one file like this without license declaration is ok

@imaffe imaffe force-pushed the affe-0705-merge-cassandra2 branch from e9ee600 to 159ef20 Compare July 6, 2020 02:07
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some useless comments, it is better to delete them.

@duhenglucky duhenglucky merged commit 564376b into apache:master Jul 28, 2020
Dreaouth pushed a commit to Dreaouth/rocketmq-externals that referenced this pull request Jul 28, 2020
…pache#587)

* feat(connect-cassanra) merge affe's cassandra connector implementation

* Merge master into current branch : deleted .iml in connect-jms

* style(connect-cassandra): resolve all TODOs and meaningless comments
odbozhou pushed a commit that referenced this pull request Mar 1, 2022
* feat(connect-cassanra) merge affe's cassandra connector implementation

* Merge master into current branch : deleted .iml in connect-jms

* style(connect-cassandra): resolve all TODOs and meaningless comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants