Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the googletest module URL #429

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented May 9, 2024

fix #427


Change logs

The googletest module code URL cannot be accessed by the community members because the original URL is not public. Change it to the public URL to make it available to community developers.

Why are the changes needed?

For a public access.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

The googletest module code URL cannot be accessed by the community
members because the original URL is not public. Change it to the public
URL to make it available to community developers.
@tuhaihe tuhaihe merged commit d32c144 into apache:main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot access the code URL for googletest to result in GitHub Dependabot can't update dependencies.
2 participants