Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dump pax tables in pg_dump #412

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

jiaqizho
Copy link
Contributor

fix #ISSUE_Number


Change logs

Pax is not working properly in pg_dump/pg_restore.

There are several problems:

  1. The pax relative table in namespace pg_ext_aux won't be dump.
  2. The table access method pax have not been setting in pg_dump.

Current change ignore pax table in pg_dump.

Why are the changes needed?

nope

Does this PR introduce any user-facing change?

nope

How was this patch tested?

none

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@jiaqizho jiaqizho requested a review from my-ship-it April 22, 2024 07:15
@jiaqizho jiaqizho force-pushed the disable-pax-in-pg-dump branch from 01f6a03 to ed70997 Compare April 23, 2024 07:24
@jiaqizho jiaqizho requested a review from gfphoenix78 April 23, 2024 07:27
@jiaqizho jiaqizho force-pushed the disable-pax-in-pg-dump branch from ed70997 to fb2cf91 Compare April 24, 2024 01:20
@my-ship-it my-ship-it merged commit f73e8c6 into apache:main Apr 28, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
Pax is not working properly in pg_dump/pg_restore.

There are several problems:
The pax relative table in namespace pg_ext_aux won't be dump.
The table access method pax have not been setting in pg_dump.
Current change ignore pax table in pg_dump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants