Don't inherit parent's reloptions if child partition's AM differs #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick from
gpdb
.This commit addresses an issue arising when creating a partitioned table with its child partitions using the classic partitioning syntax in one command. Semantically, if both the parent and the child table had specified reloptions (using the WITH clause), the child's reloptions would override the parent's.
However, in Greenplum 7, with the integration of the table AM API, the internal parsing of "appendonly" and "orientation" as reloptions has been phased out. Instead, the syntax "USING ao_{row,column}" has been standardized, effectively making "WITH (appendonly=true, orientation=xxx)" an alias.
Thus, if a child partition is created using the classic syntax, and it uses a different table access method than its parent but doesn't specify any "real" reloptions, it's better for the child not to inherit the parent's reloptions. This is because the parent's reloptions may not be compatible with the child's access method.
This commit ensures that a child partition doesn't inherit the parent's reloptions when their table access methods are different.
Fixes #14913
Reported-by: Andrew Repp [email protected]
Reviewed-by: Huansong Fu [email protected]
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳