Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reloption support for custom table access method #336

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Add reloption support for custom table access method #336

merged 4 commits into from
Dec 16, 2023

Conversation

gfphoenix78
Copy link
Contributor

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

my-ship-it
my-ship-it approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfphoenix78 gfphoenix78 merged commit ff83e0c into apache:main Dec 16, 2023
@gfphoenix78 gfphoenix78 deleted the feature-reloption branch December 18, 2023 12:08
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
@gfphoenix78
Add reloption support for custom table access method (apache#336)
c0924c3 
Add reloption support for table, custom table access method
can also have its own reloptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfphoenix78 @my-ship-it