Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): run golanci-lint on travis #773

Merged
merged 7 commits into from
Jun 27, 2019
Merged

chore(lint): run golanci-lint on travis #773

merged 7 commits into from
Jun 27, 2019

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

nicolaferraro
nicolaferraro approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good practice.

@nicolaferraro
Copy link
Member

Why travis is so slow recently? I don't think it's due to the changes in the e2e tests, it even does not start sometimes...

@nicolaferraro
Copy link
Member

I see this in the log:

$ ./golangci-lint run
ERRO Running error: context loading failed: failed to load program with go/packages: go [list -f {{context.GOARCH}} {{context.Compiler}} -- unsafe]: exit status 1: go: github.com/inconshreveable/[email protected]: git init --bare in /home/travis/gopath/pkg/mod/cache/vcs/789073dcfc473e7775315ee47ed8dda0b5d23fc69eec98221905dcf98b9d5848: exit status 128:
	fatal: cannot copy '/usr/share/git-core/templates/hooks/pre-commit.sample' to '/home/travis/gopath/pkg/mod/cache/vcs/789073dcfc473e7775315ee47ed8dda0b5d23fc69eec98221905dcf98b9d5848/hooks/pre-commit.sample': File exists

Maybe we should not continue with integration tests if lint fails.

@lburgazzoli
Copy link
Contributor Author

it should do it by default :)

@nicolaferraro
Copy link
Member

Maybe not ;)

https://medium.com/@manjula.cse/how-to-stop-the-execution-of-travis-pipeline-if-script-exits-with-an-error-f0e5a43206bf

@nicolaferraro
Copy link
Member

Why this works on Travis?? ;)

@nicolaferraro nicolaferraro merged commit bccf1f9 into apache:master Jun 27, 2019
@lburgazzoli lburgazzoli deleted the travis-lint branch June 27, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lburgazzoli @nicolaferraro