Support set integration name for kamel run #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaferraro
requested changes
Sep 12, 2018
pkg/client/cmd/run.go
Outdated
| @@ -51,6 +52,7 @@ func NewCmdRun(rootCmdOptions *RootCmdOptions) *cobra.Command { | |||
| } | |||
|
|
|||
| cmd.Flags().StringVarP(&options.Language, "language", "l", "", "Programming Language used to write the file") | |||
| cmd.Flags().StringVarP(&options.IntegrationName, "integrationName", "i", "", "The integration name") | |||
There was a problem hiding this comment.
Maybe we can use just name here to set it as --name, without short flag (i is not easy to remember, n is used for namespace).
oscerd
force-pushed
the
integration-name
branch
from
5114cb9 to
7999a42
Compare
|
Done. |
|
Nice! You should have updated your deps with the new lib. Can you add the dep files? |
|
Sure. |
|
Done |
nicolaferraro
approved these changes
Sep 12, 2018
squakez
referenced
this pull request
in squakez/camel-k
Jul 12, 2021
ENTESB-16900 fix(cli) Duplicated trait set as modeline and kamel run parameters causes error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40