Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2468: parse all YAML nodes in the tree #2476

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

nicolaferraro
Copy link
Member

Fix #2468

Release Note

NONE

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting the unit test cases. Though I think it will need a cleaner refactoring. The way it is, it's difficult to understand what it does.

@nicolaferraro
Copy link
Member Author

Trusting the unit test cases. Though I think it will need a cleaner refactoring. The way it is, it's difficult to understand what it does.

Yeah, I wanted to fully rewrite it, but there are untested things that I don't fully understand, so I opted for maintaining the structure. The relevant part for the change is probably this part that digs into all the YAML tree to later find known keywords: https://github.com/apache/camel-k/pull/2476/files#diff-7e7c57f38d81ba22aab4b4a1ef3d536b46c9d2d9432cb215059c52d57e6090efR140-R154

@nicolaferraro nicolaferraro merged commit 874e86b into apache:main Jul 1, 2021
@nicolaferraro nicolaferraro deleted the 2468-improve-yaml-parser branch July 1, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oddity in channel name
3 participants