Add option to run from URL #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add any option, I checked if the fileName provided is an url http or https and work in that direction |
nicolaferraro
requested changes
Oct 4, 2018
pkg/client/cmd/run.go
Outdated
| } else { | ||
| resp, err := http.Get(fileName) | ||
| if err != nil { | ||
| return errors.New("The URL provided is not reachable " + fileName) |
There was a problem hiding this comment.
You can use errors.wrap here (from the other errors package) so you don't lose the error cause
pkg/client/cmd/run.go
Outdated
| if err != nil { | ||
| return errors.New("The URL provided is not reachable " + fileName) | ||
| } else if resp.StatusCode != 200 { | ||
| return errors.New("The URL provided is not reachable " + fileName) |
|
Done. |
|
You mean the same also on the control on Filesystem I suppose, I'll update there too. |
|
Done |
nicolaferraro
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137