Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
const animations = (edge, path, duration) => { let timeoutId; return new Promise((resolve) => { edge.transition(path, 1, { duration: duration, timing: Timing.linear, delay: 0, complete: ({ cell, path }) => { if (animationRunning.value) { resolve(); cell.updateAttrs( { arrow1: { atConnectionRatio: 0 }, }, { silent: true } ); timeoutId = setTimeout(() => animations(cell, path, duration), 500); } else { resolve(); // 停止动画循环时,也要正常完成Promise } }, }); if (timeoutId) { clearTimeout(timeoutId); } }); };
this.queue在动画循环下,会持续增加,导致百万级别不释放,最后内存不释放
Motivation and Context
Types of changes
Self Check before Merge