Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helix coordinate and related examples/tests #6545

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 9, 2024

Checklist
  • npm test passes
image
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • Integrated helix coordinate into the core library, enabling G2 to support helix charts.
  • Added a helix demo to the official documentation site for showcasing its usage.
  • Created and finalized test files for the helix coordinate to ensure functionality and stability.
Fix this

image

image

- Integrated `helix` coordinate into the core library, enabling G2 to support helix charts.
- Added a helix demo to the official documentation site for showcasing its usage.
- Created and finalized test files for the `helix` coordinate to ensure functionality and stability.
@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12255378585

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 86.704%

Files with Coverage Reduction New Missed Lines %
src/interaction/tooltip.ts 6 90.97%
Totals Coverage Status
Change from base Build 12211940790: 0.04%
Covered Lines: 10614
Relevant Lines: 11866

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hustcc 可能需要你帮忙上传一下案例的 preview image?

@hustcc
Copy link
Member

hustcc commented Dec 10, 2024

@BQXBQX 把 demo 截图发到 issue 评论区,我上传到 oss,给你 url 地址。

@hustcc hustcc merged commit 48dcd69 into antvis:v5 Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

螺旋坐标系
4 participants