Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary structure and update label attributes #6538

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 6, 2024

Checklist
  • npm test passes
image
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • Removed redundant structure in the label rendering process.
  • Replaced elementStyle with element to expose the correct attributes in label functions.

- Removed redundant structure in the label rendering process.
- Replaced elementStyle with element to expose the correct attributes in label functions.
@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12192827959

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.66%

Totals Coverage Status
Change from base Build 12182291538: 0.0%
Covered Lines: 10611
Relevant Lines: 11866

💛 - Coveralls

@hustcc hustcc closed this Dec 6, 2024
@hustcc
Copy link
Member

hustcc commented Dec 6, 2024

这个 PR 关闭哈,还是先保持传入 elementStyle 就好。我先想想!还有点纠结~

@hustcc hustcc reopened this Dec 6, 2024
@hustcc
Copy link
Member

hustcc commented Dec 6, 2024

延续 #6536 PR,修改更合适的接口粒度。

@hustcc hustcc self-requested a review December 6, 2024 04:18
@hustcc hustcc merged commit 9d66375 into antvis:v5 Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants