refactor: reduce global redundant code #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Dec 19, 2024
|
|
||
| // use user-defined dpr first | ||
| let dpr = devicePixelRatio || (isBrowser && window.devicePixelRatio) || 1; | ||
| dpr = dpr >= 1 ? Math.ceil(dpr) : 1; |
There was a problem hiding this comment.
收敛到 g-lite 包里面了，以前是 g-lite、以及各个渲染器包里面都写了同样的代码
hustcc
approved these changes
Dec 19, 2024
wang1212
added a commit
that referenced
this pull request
Dec 20, 2024
* fix: lineDash支持多位数组 (#1867) * chore: add changeset * fix: rendering error when line break appears at the beginning of text (#1871) * docs: 修复异常示例 * refactor: reduce global redundant code (#1872) * refactor: reduce global redundant code * chore: add changeset * fix: svg path element A command drawing abnormality (#1874) * Version Packages (#1869) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: HuangLiangchen <[email protected]> Co-authored-by: wang1212 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
There are a lot of direct references to
windowin the global code, which is strongly coupled with the web platform, and the calculation ofdpris repeated in each renderer. It is easy to maintain by converging it into the core package.📝 Changelog
☑️ Self Check before Merge