Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[g-plugin-box2d] 避免重复添加 script 脚本 #1393

Closed
xiaoiver opened this issue Jun 29, 2023 · 0 comments
Closed

[g-plugin-box2d] 避免重复添加 script 脚本 #1393

xiaoiver opened this issue Jun 29, 2023 · 0 comments
Assignees
@xiaoiver
Labels
bug

Comments

@xiaoiver
Copy link
Contributor

在官网切换示例时，会重复添加 <script> 以致报错:

截屏2023-06-29 上午9 37 30 
Uncaught Error: Can only have one anonymous define call per script file
    at s.enqueueDefineAnonymousModule (loader.js:1406:23)
    at g (loader.js:1896:27)
    at VM12847 Box2D.simd.js:666:3

在插件初始化时应该首先判断在 window 下是否已经有 Box2D 对象，有就不异步加载脚本。
@xiaoiver xiaoiver self-assigned this Jun 29, 2023
@xiaoiver xiaoiver added the bug label Jun 29, 2023
xiaoiver added a commit that referenced this issue Jun 29, 2023
@xiaoiver
fix: skip loading Box2D if it's already existed #1393
ef3d0bb
xiaoiver added a commit that referenced this issue Jul 6, 2023
@xiaoiver @github-actions
Release (#1406)
654021b 
* fix: make pick async to support impl in WebGPU (#1398)

* fix: skip loading Box2D if it's already existed #1393

* fix: update latest physx

* fix: support 2 kinds of clip z range #863

* fix: make pick async to support impl in WebGPU #1400

* fix: use async readpixels in webgl2

* fix: use premultiplied alpha in WebGL & WebGPU #1399

* fix: use createImageBitmap to create texture if possible #1401

* chore: add test case for ssr with g-webgl

* chore: adjust examples of performance block (#1402)

* chore: adjust examples of performance block

* fix: reset transform with keyword none

* chore: add ga4 key

* fix: createImageBitmap should account for error of SVG failure

* fix: avoid overriding defXY when parsing path (#1405)

* fix: avoid overriding defXY when parsing path #1404

* chore: commit changeset

* chore(release): bump version (#1403)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver xiaoiver closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoiver xiaoiver

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiaoiver