Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up removeChild usages #23592

Merged
merged 1 commit into from
Oct 6, 2021
Merged

refactor: clean up removeChild usages #23592

merged 1 commit into from
Oct 6, 2021

Conversation

crisbeto
Copy link
Member

Now that we don't have to support IE11 anymore, we can use Element.remove instead of removeChild.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2021
@crisbeto crisbeto force-pushed the remove-child-cleanup branch from c18de62 to 04e3e77 Compare September 16, 2021 05:35
@crisbeto crisbeto marked this pull request as ready for review September 16, 2021 05:48
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Sep 16, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Sep 16, 2021
devversion
devversion approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you consider adding removeChild to the TSLint ban rule (if that even works)?

@crisbeto crisbeto force-pushed the remove-child-cleanup branch from 04e3e77 to ac12e2f Compare September 16, 2021 15:10
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 16, 2021
@crisbeto crisbeto force-pushed the remove-child-cleanup branch from ac12e2f to eb24b67 Compare September 16, 2021 15:11
@crisbeto crisbeto requested a review from a team as a code owner September 16, 2021 15:11
jelbourn
jelbourn approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion removed the request for review from a team September 22, 2021 17:26
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the remove-child-cleanup branch from eb24b67 to 30c2237 Compare September 24, 2021 18:09
@crisbeto
refactor: clean up removeChild usages
d4c4e56 
Now that we don't have to support IE11 anymore, we can use `Element.remove` instead of `removeChild`.
@crisbeto crisbeto force-pushed the remove-child-cleanup branch from 30c2237 to d4c4e56 Compare October 3, 2021 07:49
@mmalerba mmalerba merged commit 82072ac into angular:master Oct 6, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diicar diicar diicar left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
13.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @diicar @devversion @mmalerba