build: properly compile tests in core with Angular compiler
#60268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
added
action: review
crisbeto
approved these changes
Mar 7, 2025
Previously we never could use relative imports to import e.g. `Component` in e.g. the `core/tests/bundling` folder. This was necessary because otherwise the Angular compiler wouldn't process those files as it wouldn't recognize the Angular decorator as the one from `@angular/core`. Notably this still isn't a large issue because relative imports still work for most core tests, that are JIT compiled! For bundling tests though, or some smaller targets, our new upcoming guidelines for using relative imports inside the full package; fall apart. This commit unblocks this effort and allows us to use relative imports in all tests of `packages/core`. This is achieved by leveraging the existing `isCore` functionality of the compiler, and fixing a few instances that were missing before.
devversion
force-pushed
the
compile-core-tests
branch
from
1d40f8c to
06a41ac
Compare
devversion
added
action: merge
|
This PR was merged into the repository by commit a02e270. The changes were merged into the following branches: main, 19.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 7, 2025
Previously we never could use relative imports to import e.g. `Component` in e.g. the `core/tests/bundling` folder. This was necessary because otherwise the Angular compiler wouldn't process those files as it wouldn't recognize the Angular decorator as the one from `@angular/core`. Notably this still isn't a large issue because relative imports still work for most core tests, that are JIT compiled! For bundling tests though, or some smaller targets, our new upcoming guidelines for using relative imports inside the full package; fall apart. This commit unblocks this effort and allows us to use relative imports in all tests of `packages/core`. This is achieved by leveraging the existing `isCore` functionality of the compiler, and fixing a few instances that were missing before. PR Close #60268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we never could use relative imports to import e.g.
Componentin e.g. thecore/tests/bundlingfolder. This was necessary because otherwise the Angular compiler wouldn't process those files as it wouldn't recognize the Angular decorator as the one from@angular/core.Notably this still isn't a large issue because relative imports still work for most core tests, that are JIT compiled!
For bundling tests though, or some smaller targets, our new upcoming guidelines for using relative imports inside the full package; fall apart. This commit unblocks this effort and allows us to use relative imports in all tests of
packages/core. This is achieved by leveraging the existingisCorefunctionality of the compiler, and fixing a few instances that were missing before.