Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add manipulation of composer.json #92

Merged
merged 1 commit into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
composer-command:
- name: Generate docs
command: 'docs:generate'
directory: ['typo3-fractor']
directory: ['typo3-fractor', 'fractor-composer-json']

name: ${{ matrix.composer-command.name }}/${{ matrix.directory }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint_test_pull_requests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
command: test:php
- name: Rector
command: 'rector --dry-run'
directory: [ '', 'extension-installer', 'fractor', 'fractor-xml', 'typo3-fractor', 'fractor-doc-generator', 'fractor-yaml', 'fractor-fluid']
directory: [ '', 'extension-installer', 'fractor', 'fractor-xml', 'typo3-fractor', 'fractor-doc-generator', 'fractor-yaml', 'fractor-fluid', 'fractor-composer-json']
exclude:
- directory: extension-installer
composer-command: {name: 'PHPUnit', command: 'test:php'}
Expand Down
8 changes: 8 additions & 0 deletions fractor-composer-json/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
tests export-ignore
.gitattributes export-ignore
.gitignore export-ignore
ecs.php export-ignore
phpstan.neon export-ignore
phpunit.xml export-ignore
README.md export-ignore
rector.php export-ignore
3 changes: 3 additions & 0 deletions fractor-composer-json/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/vendor/
/composer.lock
.phpunit.cache
63 changes: 63 additions & 0 deletions fractor-composer-json/composer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
{
"name": "a9f/fractor-composer-json",
"description": "ComposerJson extension for the File Read-Analyse-Change TOol. Allows modifying composer.json files",
"license": "MIT",
"type": "fractor-extension",
"authors": [
{
"name": "Andreas Wolf",
"email": "[email protected]",
"role": "Lead Developer"
}
],
"require": {
"php": "^8.2",
"a9f/fractor": "@dev",
"a9f/fractor-extension-installer": "@dev",
"ergebnis/json-printer": "^3.5",
"eta-orionis/composer-json-manipulator": "^1.0",
"nette/utils": "^4.0",
"webmozart/assert": "^1.11"
},
"require-dev": {
"ergebnis/composer-normalize": "^2.42",
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^10.5",
"rector/rector": "^1.0",
"symplify/easy-coding-standard": "^12.1"
},
"repositories": {
"fractor": {
"type": "path",
"url": "../*"
}
},
"autoload": {
"psr-4": {
"a9f\\FractorComposerJson\\": [
"src",
"rules"
]
}
},
"autoload-dev": {
"psr-4": {
"a9f\\FractorComposerJson\\Tests\\": "tests/"
}
},
"config": {
"allow-plugins": {
"a9f/fractor-extension-installer": true,
"ergebnis/composer-normalize": true
},
"sort-packages": true
},
"scripts": {
"analyze:php": "phpstan analyze",
"docs:generate": "fractor-doc-generator generate rules --output-file docs/composer-json-fractor-rules.md",
"rector": "rector",
"style:php:check": "ecs",
"style:php:fix": "ecs --fix",
"test:php": "phpunit"
}
}
32 changes: 32 additions & 0 deletions fractor-composer-json/config/application.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

declare(strict_types=1);

use a9f\FractorComposerJson\ComposerJsonFileProcessor;
use a9f\FractorComposerJson\Contract\ComposerJsonFractorRule;
use a9f\FractorComposerJson\Contract\ComposerJsonPrinter;
use a9f\FractorComposerJson\ErgebnisComposerJsonPrinter;
use Ergebnis\Json\Printer\Printer;
use Ergebnis\Json\Printer\PrinterInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use function Symfony\Component\DependencyInjection\Loader\Configurator\tagged_iterator;

return static function (ContainerConfigurator $containerConfigurator, ContainerBuilder $containerBuilder): void {
$services = $containerConfigurator->services();
$services->defaults()
->autowire()
->autoconfigure();

$services->load('a9f\\FractorComposerJson\\', __DIR__ . '/../src/');

$services->set(ComposerJsonFileProcessor::class)
->arg('$rules', tagged_iterator('fractor.composer_json_rule'));

$services->set(Printer::class);
$services->alias(ComposerJsonPrinter::class, ErgebnisComposerJsonPrinter::class);
$services->alias(PrinterInterface::class, Printer::class);
$containerBuilder->registerForAutoconfiguration(ComposerJsonFractorRule::class)->addTag(
'fractor.composer_json_rule'
);
};
11 changes: 11 additions & 0 deletions fractor-composer-json/ecs.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

declare(strict_types=1);

return (include __DIR__ . '/../.build/ecs.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
])
;
6 changes: 6 additions & 0 deletions fractor-composer-json/phpstan.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
parameters:
level: 8

paths:
- src/
- tests/
13 changes: 13 additions & 0 deletions fractor-composer-json/phpunit.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true" cacheDirectory=".phpunit.cache">
<testsuites>
<testsuite name="fractor-composer-json">
<directory>tests</directory>
</testsuite>
</testsuites>
<source>
<include>
<directory>./src</directory>
</include>
</source>
</phpunit>
10 changes: 10 additions & 0 deletions fractor-composer-json/rector.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

return (include __DIR__ . '/../.build/rector.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
]);
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<?php
declare(strict_types=1);

namespace a9f\FractorComposerJson;

use a9f\FractorComposerJson\Contract\ComposerJson;
use a9f\FractorComposerJson\Contract\ComposerJsonFractorRule;
use a9f\FractorComposerJson\ValueObject\PackageAndVersion;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;

final class AddPackageToRequireComposerJsonFractorRule implements ComposerJsonFractorRule
{
/**
* @var PackageAndVersion[]
*/
private array $packagesAndVersions = [];

public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Add package to "require" in `composer.json`', [new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
{
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
{
"require": {
"symfony/console": "^3.4"
}
}
CODE_SAMPLE
,
[new PackageAndVersion('symfony/console', '^3.4')]
),
]);
}

public function refactor(ComposerJson $composerJson): void
{
foreach ($this->packagesAndVersions as $packageAndVersion) {
$composerJson->addRequiredPackage($packageAndVersion);
}
}

public function configure(array $configuration): void
{
Assert::allIsAOf($configuration, PackageAndVersion::class);

$this->packagesAndVersions = $configuration;
}
}
17 changes: 17 additions & 0 deletions fractor-composer-json/src/ComposerJsonFactory.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson;

use a9f\Fractor\Application\ValueObject\File;
use a9f\FractorComposerJson\Contract\ComposerJson;
use a9f\FractorComposerJson\ValueObject\EtaOrionisComposerJson;

final class ComposerJsonFactory
{
public function createFromFile(File $file): ComposerJson
{
return EtaOrionisComposerJson::fromFile($file);
}
}
51 changes: 51 additions & 0 deletions fractor-composer-json/src/ComposerJsonFileProcessor.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson;

use a9f\Fractor\Application\Contract\FileProcessor;
use a9f\Fractor\Application\ValueObject\AppliedRule;
use a9f\Fractor\Application\ValueObject\File;
use a9f\Fractor\ValueObject\Indent;
use a9f\FractorComposerJson\Contract\ComposerJsonFractorRule;
use a9f\FractorComposerJson\Contract\ComposerJsonPrinter;

final readonly class ComposerJsonFileProcessor implements FileProcessor
{
/**
* @param iterable<ComposerJsonFractorRule> $rules
*/
public function __construct(
private iterable $rules,
private ComposerJsonPrinter $composerJsonPrinter,
private ComposerJsonFactory $composerJsonFactory
) {
}

public function handle(File $file): void
{
$composerJson = $this->composerJsonFactory->createFromFile($file);
$oldComposerJson = $this->composerJsonFactory->createFromFile($file);
$ident = Indent::fromFile($file);

foreach ($this->rules as $rule) {
$rule->refactor($composerJson);

if ($oldComposerJson->getJsonArray() !== $composerJson->getJsonArray()) {
$file->changeFileContent($this->composerJsonPrinter->printToString($ident, $composerJson));
$file->addAppliedRule(AppliedRule::fromRule($rule));
}
}
}

public function canHandle(File $file): bool
{
return $file->getFileName() === 'composer.json';
}

public function allowedFileExtensions(): array
{
return ['json'];
}
}
19 changes: 19 additions & 0 deletions fractor-composer-json/src/Contract/ComposerJson.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson\Contract;

use a9f\FractorComposerJson\ValueObject\PackageAndVersion;

interface ComposerJson
{
/**
* @return mixed[]
*/
public function getJsonArray(): array;

public function addRequiredPackage(PackageAndVersion $packageAndVersion): void;

public function toJsonString(): string;
}
13 changes: 13 additions & 0 deletions fractor-composer-json/src/Contract/ComposerJsonFractorRule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson\Contract;

use a9f\Fractor\Application\Contract\ConfigurableFractorRule;
use a9f\Fractor\Application\Contract\FractorRule;

interface ComposerJsonFractorRule extends FractorRule, ConfigurableFractorRule
{
public function refactor(ComposerJson $composerJson): void;
}
12 changes: 12 additions & 0 deletions fractor-composer-json/src/Contract/ComposerJsonPrinter.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson\Contract;

use a9f\Fractor\ValueObject\Indent;

interface ComposerJsonPrinter
{
public function printToString(Indent $indent, ComposerJson $composerJson): string;
}
23 changes: 23 additions & 0 deletions fractor-composer-json/src/ErgebnisComposerJsonPrinter.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php

declare(strict_types=1);

namespace a9f\FractorComposerJson;

use a9f\Fractor\ValueObject\Indent;
use a9f\FractorComposerJson\Contract\ComposerJson;
use a9f\FractorComposerJson\Contract\ComposerJsonPrinter;
use Ergebnis\Json\Printer\PrinterInterface;

final readonly class ErgebnisComposerJsonPrinter implements ComposerJsonPrinter
{
public function __construct(
private PrinterInterface $printer
) {
}

public function printToString(Indent $indent, ComposerJson $composerJson): string
{
return $this->printer->print($composerJson->toJsonString(), $indent->toString());
}
}
Loading