-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypoScript support #85
Conversation
a9d8430
to
5ef798e
Compare
4bc3af8
to
a1bc229
Compare
2b1af1c
to
150f0db
Compare
One thing to solve here: how should a single Fractor communicate its result back to the caller? There is no clear rule for that right now, so @simonschaufi and me discussed that today. We came to the following conclusion:
This is at least similar to what Rector does, probably it's 100% the same; I did not check that again for now. Compared to the XML Fractor, an additional challenge with TS is that we need to return a list of nodes from the iterator, since there is no document node that will automatically collect all changed nodes (either directly or implicitly in its children). This needs to be solved, but is not a big deal. Deciding if a node can be handled and recording the changes and who changed what is part of the abstract base Fractor, so it must basically be reimplemented for each file type. That's not easy to change, so we accept that for now (and it leaves us more leeway to adapt things for file types where it is needed). |
packages/fractor-typoscript/src/TypoScriptStatementsIterator.php
Outdated
Show resolved
Hide resolved
packages/fractor-typoscript/tests/Fixture/StatementCollectingVisitor.php
Outdated
Show resolved
Hide resolved
packages/fractor-typoscript/tests/Fixture/StatementCollectingVisitor.php
Outdated
Show resolved
Hide resolved
cee7a2c
to
5e016f0
Compare
@simonschaufi I just resolved all remarks that will be fixed by our pipeline. No need to comment those :) |
30cee97
to
08ca0bc
Compare
A highly requested feature is missing: formatting the result with space or tab indentation. Can this be configured or is this not possible? |
4ba282a
to
23e6dfe
Compare
Also extends the e2e test script to run multiple tests and to compare the CLI output of Fractor
d7a4b6e
to
1caa2ac
Compare
Should be possible, I'll have a look. |
764433b
to
1696201
Compare
I would open an issue and postpone that for now, so we can get this merged now. |
1696201
to
a4006bc
Compare
No description provided.