[FEATURE] Add TranslationFileFractor for Yaml #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaswolf
reviewed
May 15, 2024
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace a9f\Typo3Fractor\TYPO3v10\Yaml; |
There was a problem hiding this comment.
Shouldn't this have a namespace like …\Typo3Fractor\Rules\…?
| ]); | ||
| } | ||
|
|
||
| public function refactor(array $yaml): array |
There was a problem hiding this comment.
I think we should have a common understanding of the return values of these methods in all different file types. IMO, there's three possible return types:
- a changed (part of) the file structure
- null = no change
- some flags to signal "throw this away", "stop modifying it" etc.
|
|
||
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition('Use key translationFiles instead of translationFile', [ |
There was a problem hiding this comment.
IMO this should have some reference to EXT:form in it, e.g. "Rewrite EXT:form configuration files to use key "translationFiles" instead of "translationFile" in renderingOptions."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #60