Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add fractor-fluid package #65

Merged
merged 1 commit into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint_test_pull_requests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
command: test:php
- name: Rector
command: 'rector --dry-run'
directory: [ 'extension-installer', 'fractor', 'fractor-xml', 'typo3-fractor', 'fractor-doc-generator', 'fractor-yaml']
directory: [ 'extension-installer', 'fractor', 'fractor-xml', 'typo3-fractor', 'fractor-doc-generator', 'fractor-yaml', 'fractor-fluid']
exclude:
- directory: extension-installer
composer-command: {name: 'PHPUnit', command: 'test:php'}
Expand Down
7 changes: 7 additions & 0 deletions fractor-fluid/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
ecs.php export-ignore
phpstan.neon export-ignore
README.md export-ignore
rector.php export-ignore
phpunit.xml export-ignore
tests export-ignore
.gitignore export-ignore
3 changes: 3 additions & 0 deletions fractor-fluid/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/vendor/
/composer.lock
.phpunit.cache
57 changes: 57 additions & 0 deletions fractor-fluid/composer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
{
"name": "a9f/fractor-yaml",
"description": "Fluid extension for the File Read-Analyse-Change TOol. Allows modifying Fluid files",
"license": "MIT",
"type": "fractor-extension",
"authors": [
{
"name": "Andreas Wolf",
"email": "[email protected]",
"role": "Lead Developer"
}
],
"require": {
"php": "^8.2",
"a9f/fractor": "@dev",
"a9f/fractor-extension-installer": "@dev",
"nette/utils": "^4.0",
"webmozart/assert": "^1.11"
},
"require-dev": {
"ergebnis/composer-normalize": "^2.42",
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^10.5",
"rector/rector": "^1.0",
"symplify/easy-coding-standard": "^12.1"
},
"repositories": {
"fractor": {
"type": "path",
"url": "../*"
}
},
"autoload": {
"psr-4": {
"a9f\\FractorFluid\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"a9f\\FractorFluid\\Tests\\": "tests/"
}
},
"config": {
"allow-plugins": {
"a9f/fractor-extension-installer": true,
"ergebnis/composer-normalize": true
},
"sort-packages": true
},
"scripts": {
"analyze:php": "phpstan analyze",
"rector": "rector",
"style:php:check": "ecs",
"style:php:fix": "ecs --fix",
"test:php": "phpunit"
}
}
20 changes: 20 additions & 0 deletions fractor-fluid/config/application.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

use a9f\FractorFluid\Contract\FluidFractorRule;
use a9f\FractorFluid\FluidFileProcessor;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use function Symfony\Component\DependencyInjection\Loader\Configurator\tagged_iterator;

return static function (ContainerConfigurator $containerConfigurator, ContainerBuilder $containerBuilder): void {
$services = $containerConfigurator->services();
$services->defaults()
->autowire()
->autoconfigure();

$services->load('a9f\\FractorFluid\\', __DIR__ . '/../src/');

$services->set(FluidFileProcessor::class)->arg('$rules', tagged_iterator('fractor.fluid_rule'));

$containerBuilder->registerForAutoconfiguration(FluidFractorRule::class)->addTag('fractor.fluid_rule');
};
11 changes: 11 additions & 0 deletions fractor-fluid/ecs.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

declare(strict_types=1);

return (include __DIR__ . '/../.build/ecs.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
])
;
6 changes: 6 additions & 0 deletions fractor-fluid/phpstan.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
parameters:
level: 8

paths:
- src/
- tests/
13 changes: 13 additions & 0 deletions fractor-fluid/phpunit.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true" cacheDirectory=".phpunit.cache">
<testsuites>
<testsuite name="fractor-fluid">
<directory>tests</directory>
</testsuite>
</testsuites>
<source>
<include>
<directory>./src</directory>
</include>
</source>
</phpunit>
10 changes: 10 additions & 0 deletions fractor-fluid/rector.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

return (include __DIR__ . '/../.build/rector.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
]);
12 changes: 12 additions & 0 deletions fractor-fluid/src/Contract/FluidFractorRule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

declare(strict_types=1);

namespace a9f\FractorFluid\Contract;

use a9f\Fractor\Application\Contract\FractorRule;

interface FluidFractorRule extends FractorRule
{
public function refactor(string $fluid): string;
}
44 changes: 44 additions & 0 deletions fractor-fluid/src/FluidFileProcessor.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<?php

declare(strict_types=1);

namespace a9f\FractorFluid;

use a9f\Fractor\Application\Contract\FileProcessor;
use a9f\Fractor\Application\ValueObject\AppliedRule;
use a9f\Fractor\Application\ValueObject\File;
use a9f\FractorFluid\Contract\FluidFractorRule;
use Webmozart\Assert\Assert;

final readonly class FluidFileProcessor implements FileProcessor
{
/**
* @param iterable<FluidFractorRule> $rules
*/
public function __construct(private iterable $rules)
{
Assert::allIsInstanceOf($this->rules, FluidFractorRule::class);
}

public function canHandle(File $file): bool
{
return in_array($file->getFileExtension(), $this->allowedFileExtensions(), true);
}

public function handle(File $file): void
{
foreach ($this->rules as $rule) {
$newContent = $rule->refactor($file->getContent());

if ($newContent !== $file->getContent()) {
$file->changeFileContent($newContent);
$file->addAppliedRule(AppliedRule::fromRule($rule));
}
}
}

public function allowedFileExtensions(): array
{
return ['html', 'xml', 'txt'];
}
}
25 changes: 25 additions & 0 deletions fractor-fluid/tests/Fixtures/DummyFluidFractorRule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

declare(strict_types=1);

namespace a9f\FractorFluid\Tests\Fixtures;

use a9f\FractorFluid\Contract\FluidFractorRule;
use Nette\Utils\Strings;
use Symfony\Component\DependencyInjection\Exception\BadMethodCallException;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

final class DummyFluidFractorRule implements FluidFractorRule
{
public function getRuleDefinition(): RuleDefinition
{
throw new BadMethodCallException('Not implemented yet');
}

public function refactor(string $fluid): string
{
$fluid = Strings::replace($fluid, '# noCacheHash="(1|0|true|false)"#imsU', '');

return Strings::replace($fluid, '# useCacheHash="(1|0|true|false)"#imsU', '');
}
}
13 changes: 13 additions & 0 deletions fractor-fluid/tests/FluidFileProcessor/Fixtures/fluid.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<f:link.page addQueryString="1" noCacheHash="1">Link</f:link.page>
<f:link.page addQueryString="1" noCacheHash="1">Link</f:link.page>
<f:link.page noCacheHash="0">Link</f:link.page>
<f:link.typolink useCacheHash="1">Link</f:link.typolink>
<f:link.typolink useCacheHash="0">Link</f:link.typolink>
<f:uri.typolink parameter="{link}" additionalParams="&u=b" useCacheHash="true" />
-----
<f:link.page addQueryString="1">Link</f:link.page>
<f:link.page addQueryString="1">Link</f:link.page>
<f:link.page>Link</f:link.page>
<f:link.typolink>Link</f:link.typolink>
<f:link.typolink>Link</f:link.typolink>
<f:uri.typolink parameter="{link}" additionalParams="&u=b" />
37 changes: 37 additions & 0 deletions fractor-fluid/tests/FluidFileProcessor/FluidFileProcessorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?php

declare(strict_types=1);

namespace a9f\FractorFluid\Tests\FluidFileProcessor;

use a9f\Fractor\Application\ValueObject\AppliedRule;
use a9f\Fractor\Application\ValueObject\File;
use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;
use a9f\FractorFluid\Tests\Fixtures\DummyFluidFractorRule;
use Iterator;
use PHPUnit\Framework\Attributes\DataProvider;

final class FluidFileProcessorTest extends AbstractFractorTestCase
{
#[DataProvider('provideData')]
public function test(string $filePath): void
{
$this->doTestFile($filePath);

$file = $this->fileCollector->getFileByPath($filePath);
self::assertInstanceOf(File::class, $file);
self::assertEquals([AppliedRule::fromClassString(DummyFluidFractorRule::class)], $file->getAppliedRules());
}

public static function provideData(): Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixtures', '*.html');
}

protected function additionalConfigurationFiles(): array
{
return [
__DIR__ . '/config/config.php',
];
}
}
15 changes: 15 additions & 0 deletions fractor-fluid/tests/FluidFileProcessor/config/config.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

use a9f\FractorFluid\Tests\Fixtures\DummyFluidFractorRule;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(__DIR__ . '/../../../config/application.php');

$services = $containerConfigurator->services();
$services->defaults()
->autowire()
->autoconfigure();

$services->set(DummyFluidFractorRule::class);
};