Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add interface for configurable rule #42

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

sabbelasichon
Copy link
Collaborator

No description provided.

@sabbelasichon
Copy link
Collaborator Author

@andreaswolf
Copy link
Owner

@andreaswolf Btw. that´s the reason why the guard clause https://github.com/andreaswolf/fractor/blob/main/fractor-doc-generator/src/Printer/CodeSamplePrinter.php#L54 exists

That part is still a mystery to me, but I guess it's because I've never seen an example in action. Once I (think I) understood it, I'll add documentation where appropriate :)

Copy link
Owner

@andreaswolf andreaswolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good IMO apart from the pretty generic type info :)

@sabbelasichon sabbelasichon force-pushed the add-configurable-fractor-rule branch from 4ca7b5b to f06e03a Compare April 22, 2024 08:11
@sabbelasichon sabbelasichon merged commit e64c0f3 into main Apr 22, 2024
28 checks passed
@sabbelasichon sabbelasichon deleted the add-configurable-fractor-rule branch April 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants