-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add Rule generator #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4aa7b95
to
c339079
Compare
c339079
to
f436cd4
Compare
28458ea
to
a4a4148
Compare
bcceb16
to
9fc824f
Compare
andreaswolf
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete review, did not have a look at the inner workings yet.
...emplates/rules-tests/TYPO3__MajorPrefixed__/__Type__/__Test_Directory__/Fixture/fixture.html
Outdated
Show resolved
Hide resolved
...plates/rules-tests/TYPO3__MajorPrefixed__/__Type__/__Test_Directory__/config/fractor.php.inc
Show resolved
Hide resolved
packages/fractor-rule-generator/src/Console/Command/GenerateRuleCommand.php
Show resolved
Hide resolved
packages/fractor-rule-generator/src/Factory/Typo3FractorTypeFactory.php
Outdated
Show resolved
Hide resolved
packages/fractor-rule-generator/src/FileSystem/ConfigFilesystem.php
Outdated
Show resolved
Hide resolved
packages/fractor-rule-generator/src/Console/Command/GenerateRuleCommand.php
Outdated
Show resolved
Hide resolved
packages/fractor-rule-generator/src/Console/Command/GenerateRuleCommand.php
Outdated
Show resolved
Hide resolved
packages/fractor-rule-generator/src/Console/Command/GenerateRuleCommand.php
Outdated
Show resolved
Hide resolved
9fc824f
to
6221d25
Compare
Resolves: #108
6221d25
to
ec9114d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #108