[FEATURE] Keep TypoScript format #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, will do a more thorough review tomorrow or the day after. |
simonschaufi
force-pushed
the
issue-197
branch
4 times, most recently
from
a43055c to
36be90a
Compare
andreaswolf
previously requested changes
Aug 29, 2024
There was a problem hiding this comment.
Looks good except a few minor issues. If you like I can fix them and then merge @simonschaufi.
I'll also perform a test of this on a project of mine, where I had formatting issues.
packages/fractor-typoscript/src/ValueObject/TypoScriptPrettyPrinterFormatConfiguration.php
Outdated
Show resolved
Hide resolved
packages/fractor-typoscript/src/Factory/PrettyPrinterFormatFactory.php
Outdated
Show resolved
Hide resolved
packages/fractor-typoscript/tests/TypoScriptFileProcessor/config/fractor.php
Outdated
Show resolved
Hide resolved
andreaswolf
force-pushed
the
issue-197
branch
2 times, most recently
from
6fb8ccc to
068b435
Compare
simonschaufi
commented
Aug 29, 2024
packages/fractor-typoscript/src/ValueObject/TypoScriptPrettyPrinterFormatConfiguration.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #197