Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using dry run, I want to see the file path which will be changed #195

Closed
simonschaufi opened this issue Jul 10, 2024 · 2 comments · Fixed by #211
Closed

When using dry run, I want to see the file path which will be changed #195

simonschaufi opened this issue Jul 10, 2024 · 2 comments · Fixed by #211
Labels
enhancement New feature or request

Comments

@simonschaufi
Copy link
Collaborator

Current output:

    ---------- begin diff ----------
@@ @@
 // Hide original solr info module which will be replaced by our own backend module
-options.hideModules.searchbackend = SolrInfo
+options.hideModules.searchbackend = SolrInfo
    ----------- end diff -----------

Applied rules:
RemoveUseCacheHashFromTypolinkTypoScriptFractor (https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.0/Deprecation-88406-SetCacheHashnoCacheHashOptionsInViewHelpersAndUriBuilder.html)
@andreaswolf
Copy link
Owner

I think this would be useful in general. I tried implementing it now, but with absolute paths, this will break our e2e tests (since we cannot specify an absolute path in there).

@simonschaufi Can you given an example how you think that should look? Maybe we need to work around the e2e test issue in a different way.

andreaswolf added a commit that referenced this issue Jul 13, 2024
andreaswolf added a commit that referenced this issue Jul 13, 2024
@simonschaufi simonschaufi added the enhancement New feature or request label Jul 13, 2024
@simonschaufi
Copy link
Collaborator Author

Done with #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants