-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of "Users" is ready #33
Conversation
the page still needs a good proofreading and a few illustrations and more information on a couple of featues
added missing links and missing illustration
For the proofreading, here are the typos I have noticed in the documentation :
|
I can make a few illustrations asap! edit: no further illustrations are needed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! I juste have one question regarding line 100. Should we refer to the version of eScriptorium we're using for writing the documentation?
docs/walkthrough_users.md
Outdated
- then in "password", type your password. | ||
|
||
To log out, go to the menu on the top-right cornier and select "Logout". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: corner
docs/walkthrough_users.md
Outdated
- Leaving a team, | ||
- Adding or removing members from a team, | ||
- Transfering ownership to another memer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: member
docs/walkthrough_users.md
Outdated
|
||
??? Note "No deleting, no renaming" | ||
It is currently impossible to delete a team or to rename a team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you should refer to the eScriptorium version we're using as of now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a software version for the whole tutorial, I'll try to fix it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! :)
* review done * new illustrations for invite section * minor fix before merge --------- Co-authored-by: Alix Chagué <[email protected]>
I think this branch is ready, Floriane or Hugo, do you want to squash and merge it? |
and changing date
Merging in three...two...one... |
the page still needs a good proofreading
and a few illustrations
and more information on a couple of featues