Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of "Users" is ready #33

Merged
merged 6 commits into from
Feb 13, 2023
Merged

First version of "Users" is ready #33

merged 6 commits into from
Feb 13, 2023

Conversation

alix-tz
Copy link
Owner

@alix-tz alix-tz commented Feb 7, 2023

the page still needs a good proofreading
and a few illustrations
and more information on a couple of featues

the page still needs a good proofreading
and a few illustrations
and more information on a couple of featues
added missing links and missing illustration
@alix-tz alix-tz changed the title WIP: Working on User-related features First version of "Users" is ready Feb 8, 2023
@alix-tz alix-tz requested review from FloChiff and HugoSchtr February 8, 2023 10:28
@FloChiff
Copy link
Collaborator

FloChiff commented Feb 8, 2023

For the proofreading, here are the typos I have noticed in the documentation :

  • l. 32 --> it should be "corner" and not "cornier"
  • l. 52 --> a "they" is missing in the phrase, I think it should be "that they have the right"
  • l. 64 --> "detailed" should have only one 'l' and "task" at the end of the sentence should not have any 's' as it is "a task"
  • l. 88 --> it should be "the main purpose" and not "they main purpose"
  • l. 95 --> it should be "member" and not "memer"
  • l. 97 --> "transferring" should be written with two consecutives 'r' and not juste one

@HugoSchtr
Copy link
Collaborator

HugoSchtr commented Feb 8, 2023

I can make a few illustrations asap!

edit: no further illustrations are needed. :)

Copy link
Collaborator

@HugoSchtr HugoSchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I juste have one question regarding line 100. Should we refer to the version of eScriptorium we're using for writing the documentation?

- then in "password", type your password.

To log out, go to the menu on the top-right cornier and select "Logout".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: corner

- Leaving a team,
- Adding or removing members from a team,
- Transfering ownership to another memer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: member


??? Note "No deleting, no renaming"
It is currently impossible to delete a team or to rename a team.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should refer to the eScriptorium version we're using as of now?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a software version for the whole tutorial, I'll try to fix it there

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :)

* review done

* new illustrations for invite section

* minor fix before merge

---------

Co-authored-by: Alix Chagué <[email protected]>
@alix-tz
Copy link
Owner Author

alix-tz commented Feb 13, 2023

I think this branch is ready, Floriane or Hugo, do you want to squash and merge it?

@HugoSchtr
Copy link
Collaborator

Merging in three...two...one...

@HugoSchtr HugoSchtr merged commit 4d54172 into main Feb 13, 2023
@alix-tz alix-tz deleted the fix/#21 branch February 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants