Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: migrate bytes.Buffer to strings.Builder for micro optimization #9

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

aldy505
Copy link
Owner

@aldy505 aldy505 commented Nov 5, 2021

Closes #4

@codecov-commenter
Copy link

Codecov Report

Merging #9 (3e4261d) into master (f1008bd) will increase coverage by 2.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master        #9      +/-   ##
===========================================
+ Coverage   97.86%   100.00%   +2.13%     
===========================================
  Files           9         9              
  Lines         281       275       -6     
===========================================
  Hits          275       275              
+ Misses          6         0       -6     
Impacted Files Coverage Δ
internal.go 100.00% <ø> (+54.54%) ⬆️
create.go 100.00% <100.00%> (ø)
has.go 100.00% <100.00%> (ø)
upsert.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1008bd...3e4261d. Read the comment docs.

@aldy505 aldy505 merged commit 4ec5b90 into master Nov 5, 2021
@aldy505 aldy505 deleted the perf/builder branch November 5, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from bytes.Buffer to strings.Builder for micro optimization
2 participants