Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-217): reformat guidance and explicitly state name format #1393

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

noahdietz
Copy link
Collaborator

Specific guidance for contents of unreachable: The unreachable field **must** contain service-relative resource names, and **must not** contain full resource names or simple resource IDs or resource URIs.

Clarify language regarding unreachable follow up: The service **must** provide a way for the user to get an error with additional information e.g. a Standard Get RPC or a Standard List targeted at the unreachable collection parent.

Restructure existing guidance to make each point accessible, examples clear, and exceptions isolated.

Internal bug for doc(s) and details: http://b/350788888

Note: For observers sake, the reviewers of this PR are not the only reviewers of this change, they are simply the GitHub reviewers for the changes already approved by a broader set of reviewers.

@noahdietz noahdietz requested review from jskeet and neomagus00 July 29, 2024 22:34
@noahdietz noahdietz marked this pull request as ready for review July 29, 2024 22:34
@noahdietz noahdietz requested a review from a team as a code owner July 29, 2024 22:34
@noahdietz noahdietz requested a review from neomagus00 July 30, 2024 22:44
@noahdietz noahdietz merged commit 2681e4d into aip-dev:master Jul 31, 2024
2 checks passed
@noahdietz noahdietz deleted the aip-217-contents branch July 31, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants