Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-122): clarify shortening rules for nested collections #1372

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

noahdietz
Copy link
Collaborator

While implementing rules for singular/plural presence in pattern values including the nested collection exception, I noticed that the guidance was vague for each specific field in the google.api.resource annotation.

@noahdietz noahdietz requested a review from a team as a code owner June 14, 2024 20:54
@noahdietz noahdietz requested review from loudej and hrasadi June 14, 2024 20:54
@noahdietz noahdietz removed request for loudej and hrasadi June 14, 2024 21:17
@noahdietz noahdietz requested review from itsStrobe and jskeet June 24, 2024 00:35
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I'd still like to hear more about the intended uses for singular and plurals in a meeting - I haven't been tracking this closely enough.

@noahdietz noahdietz requested a review from jskeet June 25, 2024 23:48
@noahdietz
Copy link
Collaborator Author

Think I'd still like to hear more about the intended uses for singular and plurals in a meeting - I haven't been tracking this closely enough.

They are used for a few different things but mostly to give an authoritative field within the annotation to define the words so that those usages of the resource singular & plural forms aren't left to guess it from the pattern or type

https://github.com/googleapis/googleapis/blob/46eb6505cc4b8340d304510d7226de96bafe9314/google/api/resource.proto#L180-L193

@SsomsakTH

This comment was marked as duplicate.

@noahdietz noahdietz enabled auto-merge (squash) June 28, 2024 20:32
@noahdietz noahdietz merged commit c74c792 into aip-dev:master Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants